Attention is currently required from: Julius Werner, Jérémy Compostella, Subrata Banik.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85905?usp=email )
Change subject: drivers/option: Add CBFS file based option backend ......................................................................
Patch Set 12:
(4 comments)
Patchset:
PS4:
Wait, why would we want this? I don't see why a mainboard should select an option backend by default […]
I had similar thoughts initially which is why I had asked about it. Leaving the code as is for now until this gets sorted out for your use case. I see that CB:86001 currently uses `HAVE_CBFS_FILE_OPTION_BACKEND`.
Commit Message:
https://review.coreboot.org/c/coreboot/+/85905/comment/8d35d666_0587f071?usp... : PS9, Line 11: prefix. Options should be stored in cbfs with the option/ prefix. Values
As to my knowledge CBFS is acronym standing for CoreBoot File System CBFS, I would suggest to spell […]
Done
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/85905/comment/7f84f380_3ec715cf?usp... : PS9, Line 172: option-name
should say `-n option/<option-name>`
Done
File src/include/option.h:
https://review.coreboot.org/c/coreboot/+/85905/comment/53595c95_840730af?usp... : PS9, Line 27: #define set_uint_option(name, value) do_set_uint_option("option/" name, value)
I guess this works but isn't it a bit overkill just to prepend the string? You could've just done so […]
Done. Thanks for the suggestion.