Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44241 )
Change subject: cpu/intel/model_6xx: Unify all Slot 1 CPUs ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44241/4/src/cpu/intel/model_6xx/mod... File src/cpu/intel/model_6xx/model_6xx_init.c:
https://review.coreboot.org/c/coreboot/+/44241/4/src/cpu/intel/model_6xx/mod... PS4, Line 26: if ((dev->device & 0x0ff0) == 0x0680 || (dev->device & 0x0ff0) == 0x06b0) { : char processor_name[49]; : : fill_processor_name(processor_name); : printk(BIOS_INFO, "CPU: %s.\n", processor_name); : } I don't think it makes sense to print the processor name on just these CPU's. One could just check in fill_processor_name() if CPUID.EAX=0x80000004 is supported and change the return type to report fail/success.