Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31178 )
Change subject: mb/google/hatch: Reconfigure SD card detect GPIO host software ownership
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31178/1/src/mainboard/google/hatch/variants/...
PS1, Line 141: PAD_CFG_GPI_GPIO_DRIVER
Does it not result in any issues if CD# is not configured as native function for the SD controller?
I want to understand this better before the change gets pushed in. Why does this pin have to be configured in GPIO mode? Wouldn't the SD controller want it to be in native mode?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31178
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id214184f3e183f6feb6887484cd4ccd3bab65b1a
Gerrit-Change-Number: 31178
Gerrit-PatchSet: 1
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 03 Feb 2019 19:35:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment