Attention is currently required from: Robert Zieba, Reka Norman, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63281 )
Change subject: util/spd_tools: Add ability to override SPD file for parts
......................................................................
Patch Set 2:
(2 comments)
File util/spd_tools/README.md:
https://review.coreboot.org/c/coreboot/+/63281/comment/25dfe9fa_2c4796da
PS2, Line 467: * for in the spd directory, if it is not found there then it will be searched for in the
This order should be reversed. i.e. a local SPD file should override the common SPD file.
https://review.coreboot.org/c/coreboot/+/63281/comment/8e955aa3_5876b73f
PS2, Line 478: H5AN8G6NDJR-XNC,8
I assume there's nothing preventing using one of the common generic SPDs here. e.g. H5AN8G6NDJR-XNC,8,spd-5.hex?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63281
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I078dd04fead2bf19f53bc6ca8295187d439adc20
Gerrit-Change-Number: 63281
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 31 Mar 2022 22:25:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment