build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32905 )
Change subject: RFC: smbios: allow setting BIOS-version string from VPD variable ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32905/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32905/1/src/arch/x86/smbios.c@358 PS1, Line 358: /* if found, vpd value will be terminated by 0x00 (VPD_TYPE_TERMINATOR) */ line over 80 characters
https://review.coreboot.org/#/c/32905/1/src/arch/x86/smbios.c@359 PS1, Line 359: if(coreboot_vpd_version) space required before the open parenthesis '('