Craig Hesling has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38623 )
Change subject: hatch/mushu: Fix FPMCU pwr/rst gpio handling
......................................................................
Patch Set 6:
(2 comments)
Thanks for the look Paul!
Please take another look.
https://review.coreboot.org/c/coreboot/+/38623/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38623/4//COMMIT_MSG@10
PS4, Line 10: and removes FPMCU control from the RO image.
Why?
Done
https://review.coreboot.org/c/coreboot/+/38623/4//COMMIT_MSG@12
PS4, Line 12: https://review.coreboot.org/c/coreboot/+/37459
Please use commit hash or Change-Id and the summary when referencing other commits.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38623
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12dc0c3bead7672e2d3207771212efb0d246973a
Gerrit-Change-Number: 38623
Gerrit-PatchSet: 6
Gerrit-Owner: Craig Hesling
hesling@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Craig Hesling
hesling@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 31 Jan 2020 18:11:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment