Attention is currently required from: Raul Rangel, Jon Murphy, Eric Lai, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74100 )
Change subject: mb/google/myst: Add smihandler
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/myst/variants/baseboard/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74100/comment/34299d75_da9c9ff9
PS6, Line 5: smm-y += gpio.c
Missing `smihandler.c`.
File src/mainboard/google/myst/variants/baseboard/smihandler.c:
https://review.coreboot.org/c/coreboot/+/74100/comment/2f19805e_4a5c60ee
PS6, Line 10: void mainboard_smi_sleep(u8 slp_typ)
Missing these calls from Skyrim:
```
variant_sleep_gpio_table(&gpios, &num_gpios);
gpio_configure_pads(gpios, num_gpios);
```
Is that work done somewhere else, or unnecessary?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74100
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92e5e6aef7ab0b84a96d976e29ebf96b56f6f1a1
Gerrit-Change-Number: 74100
Gerrit-PatchSet: 6
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:58:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment