Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38920/9/src/mainboard/gigabyte/ga-z...
File src/mainboard/gigabyte/ga-z170x-gaming7/romstage.c:
https://review.coreboot.org/c/coreboot/+/38920/9/src/mainboard/gigabyte/ga-z...
PS9, Line 24: const u16 RcompResistor[3] = { 200, 81, 162 };
121, 75, 100
Just take these numbers. Intel secret documents list them for SKL-H
and CML-S, plus Angel confirmed that the resistors on the bottom of
a SKL-S CPU match.
https://review.coreboot.org/c/coreboot/+/38920/9/src/mainboard/gigabyte/ga-z...
PS9, Line 33: 100, 40, 40, 23, 40 };
What about this one?
Same here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38920
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c69bddd22cbd8f797dbb57370a4d8e5afa63bc
Gerrit-Change-Number: 38920
Gerrit-PatchSet: 9
Gerrit-Owner: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Feb 2020 22:18:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christoph Pomaska
github@slrie.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment