[coreboot-gerrit] Change in coreboot[master]: riscv: add support for OpenSBI

[Xiang Wang (Code Review)]

Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32394 )

Change subject: riscv: add support for OpenSBI
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/32394/4/src/soc/sifive/fu540/Kconfi... 
File src/soc/sifive/fu540/Kconfig:

https://review.coreboot.org/c/coreboot/+/32394/4/src/soc/sifive/fu540/Kconfi... 
PS4, Line 52: OPENSBI_PLATFORM
This needs to be used in src/arch/riscv/Makefile.inc

$(OPENSBI): $(obj)/config.h | $(OPENSBI_SOURCE)
    printf "    MAKE       $(subst $(obj)/,,$(@))\n"
    mkdir -p $(OPENSBI_BUILD)
    $(MAKE) \
    	-C "$(OPENSBI_SOURCE)" \
    	CC="$(CC_ramstage)" \
    	LD="$(LD_ramstage)" \
    	OBJCOPY="$(OBJCOPY_ramstage)" \
    	AR="$(AR_ramstage)" \
    	PLATFORM=$(CONFIG_OPENSBI_PLATFORM) \
    	O="$(OPENSBI_BUILD)" \
    	FW_JUMP=y \
    	FW_DYNAMIC=y \
    	FW_PAYLOAD=n \
    	FW_PAYLOAD_OFFSET=0 \
    	FW_TEXT_START=$(CONFIG_OPENSBI_TEXT_START)
    mv $(OPENSBI_TARGET) $@

https://review.coreboot.org/c/coreboot/+/32394/4/src/soc/sifive/fu540/Kconfi... 
PS4, Line 56: endif
Maybe missing the definition of OPENSBI_TEXT_START