build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34711 )
Change subject: google/mistral: LED Pattern change ......................................................................
Patch Set 8:
(41 comments)
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... File src/drivers/i2c/lp5562/led_lp5562_programs.c:
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 73: }}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 134: }}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 201: }}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 215: 10 11 40CC set_pwm 0 please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 247: }}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 281: }}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 284: {LED_ALL_OFF, {&solid_000000_program}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 285: {LED_RECOVERY_PUSHED, {&fdr_press1_program}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 286: {LED_WIPEOUT_REQUEST, {&wipeout_request1_program}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 287: {LED_RECOVERY_REQUEST, {&blink_recovery1_program}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 288: {LED_NORMAL_BOOT, {&preboot1_program}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 297: {blue, set_pwm, 0x00, 0, {}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 298: {green, set_pwm, 0x10, 0, {}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 299: {red, set_pwm, 0x20, 0, {}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 300: {0, invalid, 0x00, 0, {}}}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 307: {blue, set_pwm, 0x01, 0, {}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 308: {green, set_pwm, 0x11, 0, {}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 309: {red, set_pwm, 0x21, 0, {}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 310: {0, invalid, 0x00, 0, {}}}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 321: { Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 323: }}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 328: { Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 330: }}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 335: { Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 337: }}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 338: {0, invalid, 0x00, 0, {}}}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 344: {blue, ramp, 0x02, 2, {{250, 128}, {250, 128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 345: {blue, ramp, 0x05, 2, {{250, -128}, {250, -128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 346: {green, ramp, 0x12, 2, {{250, 128}, {250, 128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 347: {green, ramp, 0x15, 2, {{250, -128}, {250, -128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 348: {red, ramp, 0x22, 2, {{250, 128}, {250, 128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 349: {red, ramp, 0x25, 2, {{250, -128}, {250, -128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 350: {0, invalid, 0x00, 0, {}}}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 356: {blue, ramp, 0x02, 2, {{250, 128}, {250, 128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 357: {blue, ramp, 0x05, 2, {{250, -128}, {250, -128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 358: {green, ramp, 0x12, 2, {{250, 128}, {250, 128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 359: {green, ramp, 0x15, 2, {{250, -128}, {250, -128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 360: {red, ramp, 0x24, 2, {{250, 128}, {250, 128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 361: {red, ramp, 0x27, 2, {{250, -128}, {250, -128}}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 362: {0, invalid, 0x00, 0, {}}}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/34711/8/src/drivers/i2c/lp5562/led_... PS8, Line 389: {NULL, 0, 0, NULL}}; space required after that close brace '}'