Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )
Change subject: amd/picasso: Load x86 microcode from CBFS modules
......................................................................
Patch Set 20:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41719/20/src/soc/amd/picasso/update...
File src/soc/amd/picasso/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/41719/20/src/soc/amd/picasso/update...
PS20, Line 52: (new_patch_id == m->patch_id) ? "success" : "fail");
microcode: Updating to patch id = 0x%08x %s\n … succeeded/failed
The success message level should be `BIOS_INFO`, the failure message level should be `BIOS_ERR`.
https://review.coreboot.org/c/coreboot/+/41719/20/src/soc/amd/picasso/update...
PS20, Line 69: m++) {
This fits on the line above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib08a65b93c045afc97952a809670c85831c0faf7
Gerrit-Change-Number: 41719
Gerrit-PatchSet: 20
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: Zheng Bao
zheng.bao@amd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jun 2020 08:18:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment