Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34599 )
Change subject: lib/coreboot_table: Show splashscreen in lb_table_init
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34599/2/src/device/Kconfig
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/34599/2/src/device/Kconfig@441
PS2, Line 441: depends on LINEAR_FRAMEBUFFER
Should the configuration be limited to the qemu target?
Done
https://review.coreboot.org/c/coreboot/+/34599/2/src/device/Kconfig@450
PS2, Line 450: It might not be implemented for every framebuffer initialization platform.
I don't see why. See comment in src/drivers/emulation/qemu/bochs. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34599
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bec06d22423627e8f429c4b47e0dc9920f1464e
Gerrit-Change-Number: 34599
Gerrit-PatchSet: 4
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Gerd Hoffmann
kraxel@redhat.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Tue, 30 Jul 2019 12:49:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mimoja
coreboot@mimoja.de
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment