Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34304 )
Change subject: Revert "{drivers,soc/intel/braswell}: Implement C_ENVIRONMENT_BOOTBLOCK support"
......................................................................
Patch Set 1: -Code-Review
I suggest using (and fix Google/Cyan) C_ENVIRONMENT_BOOTBLOCK or make C_ENVIRONMENT_BOOTBLOCK optional.
we've tried fixing Cyan without much luck, and in the interest of not having it broken for the 4.10 release, I'd suggest we make C_ENVIRONMENT_BOOTBLOCK the default (since all new boards should be able to use it) and add a Kconfig for the original implementation which Cyan (and Strago) will select (USE_DEPRECATED_ROMCC_BOOTBLOCK ?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34304
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67b68f0d6154249ab2633997f29c0a1699ef0c76
Gerrit-Change-Number: 34304
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: York Yang
yyang024@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jul 2019 14:50:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment