[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77...

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33147 )

Change subject: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77 deg C
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/... 
PS3, Line 191: on
> why we need to enable this device just for LTT programming ? this can be achieved using temp bar. […]

wrong, we should never operate on devices that are marked off.
Ideally those devices are disabled using FD bits and might not decode anything valid.