Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31435
to look at the new patch set (#2).
Change subject: mb/ocp/monolake: fix for booting issues + tmp and ipmi support ......................................................................
mb/ocp/monolake: fix for booting issues + tmp and ipmi support
This change brings monolake platform to sane state when it actually boots.
First of all - we experienced booting issues during FSP-M phase. Applying fix that was introduced for wedge100s - 817994c1bec - helped and systems started to boot properly.
Secondly, changes includes: - enabled TPM1 + added entry in devicetree - configured LPC IO to make IPMI work + added entry in devicetree - introduced DSDT and SMBIOS entries for IPMI to make it detectable
Also I changed the length of SMBIOS type 38 entry. Subtracting 2 of it was effectively cutting information about register spacing, don't know why was it there on the first place.
Signed-off-by: Lukasz Siudut lsiudut@fb.com Change-Id: Ibfbe9d19c7413098c56d1b6131640097fdf731ab --- M src/arch/x86/smbios.c M src/mainboard/ocp/monolake/Kconfig M src/mainboard/ocp/monolake/devicetree.cb M src/mainboard/ocp/monolake/dsdt.asl M src/mainboard/ocp/monolake/mainboard.c M src/mainboard/ocp/monolake/romstage.c 6 files changed, 172 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/31435/2