David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35367 )
Change subject: mb/ocp/monolake: Add GPIO table to initialize custom configs
......................................................................
Patch Set 6: Code-Review+2
I got some advice from another member in the community to interleave comments and code to avoid hitting the line width limit. In the interest of time I went ahead and implemented that suggestion so we can hopefully get this patch merged soon.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74906bf9395a333be6250ffbd181da536e016f30
Gerrit-Change-Number: 35367
Gerrit-PatchSet: 6
Gerrit-Owner: Jingle Hsu
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 18:46:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment