Attention is currently required from: Jérémy Compostella, Krishna P Bhat D, Rizwan Qureshi, Subrata Banik, sridhar siricilla.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77069?usp=email )
Change subject: soc/intel/cse: Implement APIs to access PSR backup status in CMOS
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/77069/comment/aa7c53ea_8017584e :
PS5, Line 171: 0x55
No specific meaning, this value is chosen by us. […]
Hi Subrata , We kept the values 0x55 and 0x22 to make sure these are not commonly occuring values like 0/1 . So we suggest to have them 0x55/0x22 to ensure it doesn't coincide with default cmos values during bootup
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77069?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I270894e3e08dd50ca88e5402b59c211d7e693d14
Gerrit-Change-Number: 77069
Gerrit-PatchSet: 7
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Tue, 26 Sep 2023 18:04:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-MessageType: comment