Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49895 )
Change subject: mb/ocp/deltalake: Replace space with underscore in Locator string ......................................................................
mb/ocp/deltalake: Replace space with underscore in Locator string
Per Facebook BIOS requirements 'Locator' field should not have any space between words.
Tested=On OCP Delta Lake, dmidecode -t 17 to verify.
Change-Id: I2f6f1b2590c55d6da4ca32aef2f50eb332f441dc Signed-off-by: Johnny Lin johnny_lin@wiwynn.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49895 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jonathan Zhang jonzhang@fb.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/ocp/deltalake/ramstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Jonathan Zhang: Looks good to me, approved
diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 7498063..4a3e385 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -320,7 +320,7 @@ { char buf[40];
- snprintf(buf, sizeof(buf), "DIMM %c0", 'A' + dimm->channel_num); + snprintf(buf, sizeof(buf), "DIMM_%c0", 'A' + dimm->channel_num); t->device_locator = smbios_add_string(t->eos, buf);
snprintf(buf, sizeof(buf), "_Node0_Channel%d_Dimm0", dimm->channel_num);