build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34946 )
Change subject: WIP: add src/mainboard/hp/spectre_x360_13t_ae000 port
......................................................................
Patch Set 28:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34946/28/src/mainboard/hp/spectre_x...
File src/mainboard/hp/spectre_x360_13t_ae000/romstage.c:
https://review.coreboot.org/c/coreboot/+/34946/28/src/mainboard/hp/spectre_x...
PS28, Line 79: udelay(10000);
long udelay - prefer mdelay; see arch/arm/include/asm/delay.h
https://review.coreboot.org/c/coreboot/+/34946/28/src/mainboard/hp/spectre_x...
PS28, Line 91: memcpy(&mem_cfg->RcompResistor, rcomp_resistor,
trailing whitespace
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie744cdccd3d110b4137e0b017b3f8497d23c0497
Gerrit-Change-Number: 34946
Gerrit-PatchSet: 28
Gerrit-Owner: Matt Parnell
mparnell@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Parnell
mparnell@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Sep 2019 02:51:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment