Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48251 )
Change subject: soc/intel/common/block/lpc: Include correct acpi.h ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48251/3/src/soc/intel/common/block/... File src/soc/intel/common/block/lpc/lpc.c:
https://review.coreboot.org/c/coreboot/+/48251/3/src/soc/intel/common/block/... PS3, Line 14: <soc/acpi.h>
Humm.. I think long term we should do one of the following: […]
#2 doesn't seem correct either and could make the common block stuff very confusing if the header is not with the source. There is a lot of dependencies in the common code and they are all #if CONFIG and/or if CONFIG blocks. COMMON LPC expects southbridge_write_acpi_tables(), but it could be called by and soc that doesn't use common LPC (but there aren't any, currently).
I understand your point that it is not explicitly which header file is picked up with soc/acpi.h, but it is widely used in the soc/intel socs and you would expect it to pick up the soc it is building. It would be no more confusing than the southbridge_write_acpi_tables() being in lpc.h. *shrug*
It seems that this is the simplest solution, but will accept something that moves this forward.