Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34939 )
Change subject: Add new ENV_xxx definitions ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34939/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34939/10//COMMIT_MSG@9 PS10, Line 9: ENV_BEFORE_RAMSTAGE is the generic replacement for __PRE_RAM__. I think it would make more sense that ENV_ROMSTAGE_OR_BEFORE is the new generic replacement for __PRE_RAM__, and ENV_BEFORE_RAMSTAGE can be used where postcar must explicitly be included. Just because no other architectures currently have special stages between romstage and ramstage doesn't mean they never will. (In fact, that used to be possible for a while on all architectures with the combination of CONFIG_VBOOT_STARTS_IN_ROMSTAGE and CONFIG_VBOOT_SEPARATE_VERSTAGE already, until we removed that case.)
https://review.coreboot.org/c/coreboot/+/34939/10/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/34939/10/src/include/rules.h@276 PS10, Line 276: !CONFIG(ARCH_X86)
ENV_CACHE_AS_RAM is poor in the sense it does not give any clue that you cannot have mutable . […]
Well, if you want to know whether you have a .data section you should use ARCH_STAGE_HAS_DATA_SECTION anyway. Maybe the right answer here is that we should only use that and don't need another option next to it. (Maybe we should rename those to ENV_HAVE_DATA_SECTION, etc. as well to make naming a bit more consistent.)
Anyway, having an ENV_PROGRAM_IN_RAM that includes SRAM will be very confusing to people working on those systems, let's please not do that.