HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )
Change subject: src: Fix - Remove unused variables
......................................................................
Patch Set 23:
(1 comment)
https://review.coreboot.org/#/c/29917/23/src/northbridge/intel/pineview/earl...
File src/northbridge/intel/pineview/early_init.c:
https://review.coreboot.org/#/c/29917/23/src/northbridge/intel/pineview/earl...
PS23, Line 125: reg32 = MCHBAR32(0x30);
: reg32 = 0x21800;
: MCHBAR32(0x30) = reg32;
: DMIBAR32(0x2c) = 0x86000040;
: pci_write_config32(PCI_DEV(0, 0x1e, 0), 0x18, 0x00020200);
: pci_write_config32(PCI_DEV(0, 0x1e, 0), 0x18, 0x00000000);
:
: early_graphics_setup();
:
: reg32 = MCHBAR32(0x40);
: reg32 = 0x0;
: MCHBAR32(0x40) = reg32;
: reg32 = MCHBAR32(0x40);
: reg32 = 0x8;
: MCHBAR32(0x40) = reg32;
This is unrelated to the description and doesn't make the code more readable
if we enable "Wunused", we'll have a complain that "reg32 is unused".
I'll add a this to commit msg.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837
Gerrit-Change-Number: 29917
Gerrit-PatchSet: 23
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Thu, 17 Jan 2019 07:48:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment