Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42258 )
Change subject: Chrome EC SOCs: Integrate Chrome EC check
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42258/2/src/soc/amd/picasso/acpi.c
File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/42258/2/src/soc/amd/picasso/acpi.c@...
PS2, Line 259: if (CONFIG(EC_GOOGLE_CHROMEEC)) {
: gnvs->chromeos.vbt2 = google_ec_running_ro() ?
: ACTIVE_ECFW_RO : ACTIVE_ECFW_RW;
: } else {
: gnvs->chromeos.vbt2 = ACTIVE_ECFW_RO;
: }
Thank you for the suggestions. […]
I will have a suggestion on this as I work thru common GNVS setup framework. The entire APM_CNT_GNVS_UPDATE stuff can be thrown out.. will be like +50 -500 commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42258
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43ff551c717f598c7a65547ec49157853681314f
Gerrit-Change-Number: 42258
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 17 Jun 2020 05:05:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment