Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33147 )
Change subject: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77 deg C
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33147/6/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/hatch/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/33147/6/src/mainboard/google/hatch/...
PS6, Line 57: .pch_thermal_trip = 77,
Sure, will do that.
You can add this to baseboard/devicetree.cb:
register "common_soc_config.pch_thermal_trip" = "77" and that should take effect for all variants.
One word of caution: If a variant wants to override this value, they will have to use the same format i.e register "ommon_soc_config.pch_thermal_trip" = "xy" instead of putting it under register "common_soc_config". This is because of the way overrides are currently applied in sconfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib20fae04080b28c6105e5a187cc5d7a55b48d709
Gerrit-Change-Number: 33147
Gerrit-PatchSet: 6
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 29 Jul 2019 19:28:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment