Hello Richard Spiegel, Martin Roth, Furquan Shaikh,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/32662
to review the following change.
Change subject: soc/amd/stoneyrige: Add ALink-AHB Bridge to iomap.h ......................................................................
soc/amd/stoneyrige: Add ALink-AHB Bridge to iomap.h
Add the address and replace the hardcoded value in the ASL code.
Change-Id: If0b99de78d8c5948e2e5f2aa50dfc2efc1bd1ba1 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/stoneyridge/acpi/sb_fch.asl M src/soc/amd/stoneyridge/include/soc/iomap.h 2 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/32662/1
diff --git a/src/soc/amd/stoneyridge/acpi/sb_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_fch.asl index 4c1196d..e7975f8 100644 --- a/src/soc/amd/stoneyridge/acpi/sb_fch.asl +++ b/src/soc/amd/stoneyridge/acpi/sb_fch.asl @@ -22,7 +22,7 @@ Name (_UID, 0x0) Name (_CRS, ResourceTemplate() { - Memory32Fixed (ReadWrite, 0xFEDC0000, 0x2000) + Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000) })
Method (_STA, 0x0, NotSerialized) diff --git a/src/soc/amd/stoneyridge/include/soc/iomap.h b/src/soc/amd/stoneyridge/include/soc/iomap.h index 7762043..3856a22 100644 --- a/src/soc/amd/stoneyridge/include/soc/iomap.h +++ b/src/soc/amd/stoneyridge/include/soc/iomap.h @@ -25,10 +25,12 @@ /* AcpiMmio blocks are at fixed offsets from FED8_0000h, enabled in PMx04[1] */ #include <amdblocks/acpimmio_map.h>
+#define ALINK_AHB_ADDRESS 0xfedc0000 + /* I2C fixed address */ -#define I2C_BASE_ADDRESS 0xfedc2000 -#define I2C_DEVICE_SIZE 0x00001000 -#define I2C_DEVICE_COUNT 4 +#define I2C_BASE_ADDRESS 0xfedc2000 +#define I2C_DEVICE_SIZE 0x00001000 +#define I2C_DEVICE_COUNT 4
#if CONFIG(HPET_ADDRESS_OVERRIDE) #error HPET address override is not allowed and must be fixed at 0xfed00000