Attention is currently required from: Andrey Petrov, Bora Guvendik, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Ronak Kanabar, Subrata Banik, Tarun, Wonkyu Kim.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80275?usp=email )
Change subject: drivers/intel/fsp2_0: Add FSP 2.4 support
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/80275/comment/282dd4ce_7625bbe2 :
PS2, Line 82: FSPS_ARCHx_UPD *s_arch_cfg = &supd->FspsArchUpd;
`need consistent spacing around '*' (ctx:WxV)`
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80275?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c24d26e105c3dcbd9cca0e7197ab1362344aa97
Gerrit-Change-Number: 80275
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Wed, 31 Jan 2024 20:18:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment