Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36654 )
Change subject: libpayload: keyboard: Ignore special keys
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36654/10/payloads/libpayload/includ...
File payloads/libpayload/include/libpayload.h:
https://review.coreboot.org/c/coreboot/+/36654/10/payloads/libpayload/includ...
PS10, Line 68: #include <keycodes.h>
Sure Eric, we can do that.
sorry for the confusion, keycodes.h is under libpayload/include. So, I included it directly in depthcharge(board.c) as it has access to LIBPAYLOAD_DIR(/build/drallion/firmware/libpayload)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36654
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c11939d18391bebe53ca21cf33a096ba369cd56
Gerrit-Change-Number: 36654
Gerrit-PatchSet: 13
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Nov 2019 00:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-MessageType: comment