HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44835 )
Change subject: src/{device,include}: Use PNP_IDX_EN instead of magic number ......................................................................
Patch Set 2:
(1 comment)
Thank you
https://review.coreboot.org/c/coreboot/+/44835/2/src/device/pnp_device.c File src/device/pnp_device.c:
https://review.coreboot.org/c/coreboot/+/44835/2/src/device/pnp_device.c@7 PS2, Line 7: #include <device/pnp.h>
is it intended that device/pnp_def. […]
I forget to add that include. But I like the idea to suppose that <device/pnp.h> provides indirectly <device/pnp_def.h> (when device/pnp.h is needed).
it needs a separate patch (if you also like the idea).