Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56130 )
Change subject: Revert "Makefile.inc: Drop the cbfs master header from non-X86"
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56130/comment/22bb31e4_90a14e54
PS1, Line 11: Breaks libpayload CBFS code when accessing
: non-primary CBFS.
I see that there is FMAP support in libpayload. […]
(In fact I just remembered FMAP cache isn't optional in CBMEM, only in SRAM. In CBMEM it should always exist. So libpayload should always be able to just grab it out of there and doesn't even have to worry about flash access then, at least for the FMAP part.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7f47406e6126f19e1fd6bc9d33c8c9d0cb9450d
Gerrit-Change-Number: 56130
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 09 Jul 2021 00:55:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment