HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45192 )
Change subject: soc/intel/alderlake/romstage: Do initial SoC commit till romstage
......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45192/7/src/soc/intel/alderlake/esp...
File src/soc/intel/alderlake/espi.c:
https://review.coreboot.org/c/coreboot/+/45192/7/src/soc/intel/alderlake/esp...
PS7, Line 13: <arch/io.h>
not used ?
https://review.coreboot.org/c/coreboot/+/45192/7/src/soc/intel/alderlake/esp...
PS7, Line 15: <arch/ioapic.h>
not used?
please check the other includes.
https://review.coreboot.org/c/coreboot/+/45192/7/src/soc/intel/alderlake/inc...
File src/soc/intel/alderlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/45192/7/src/soc/intel/alderlake/inc...
PS7, Line 9: size_t
<stddef.h> ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45192
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4473aed27363c22e92e66cc6770cb55aae83e75c
Gerrit-Change-Number: 45192
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sun, 13 Sep 2020 20:04:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment