huayang duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32010 )
Change subject: mediatek/mt8183: enable DDR low power feature ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/32010/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32010/1//COMMIT_MSG@8 PS1, Line 8:
Please describe, what the feature does. […]
this patch just for DDR low power setting, patch is not optional. we do not measure the power saved. this patch no side affect of performance.
https://review.coreboot.org/#/c/32010/1/src/soc/mediatek/mt8183/dramc_pi_bas... File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:
https://review.coreboot.org/#/c/32010/1/src/soc/mediatek/mt8183/dramc_pi_bas... PS1, Line 339:
One blank line should be enough, shouldn’t it?
Done
https://review.coreboot.org/#/c/32010/2/src/soc/mediatek/mt8183/emi.c File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/#/c/32010/2/src/soc/mediatek/mt8183/emi.c@297 PS2, Line 297: clrsetbits_le32
use clrbits_le32?
Done