build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29256 )
Change subject: soc/amd/stoneyridge: SMBUS access through MMIO ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/29256/1/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/smbus.h:
https://review.coreboot.org/#/c/29256/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 23: #define SMB_RD(base, reg) read8((void*)SMBUS_MMIO_BASE + reg) "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/29256/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 24: #define SMB_WR(value, base, reg) write8((void*)SMBUS_MMIO_BASE + reg, \ "(foo*)" should be "(foo *)"