[coreboot-gerrit] [M] Change in coreboot[main]: src/mainboard/siemens/fa_ehl: Configure LPDDR4 initialization

[Paul Menzel (Code Review)]

Attention is currently required from: Johannes Hahn, Mario Scheithauer, Werner Zeh.

Paul Menzel has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/86424?usp=email )

Change subject: src/mainboard/siemens/fa_ehl: Configure LPDDR4 initialization
......................................................................

Patch Set 6:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86424/comment/9e2fb0c8_cdb62f24?usp... :
PS6, Line 7: src/
This can also be removed.

File src/mainboard/siemens/fa_ehl/variants/fa_ehl/memory.c:

https://review.coreboot.org/c/coreboot/+/86424/comment/e3738d89_e1ab98e5?usp... :
PS5, Line 4: #include <gpio.h>
> Should the whole patch be abandoned so I can dissolve remnant dependencies of it before commiting it […]

Sorry, I don’t fully understand. In my opinion the patchset should stay, and you should just amend the commit.