[coreboot-gerrit] [XS] Change in coreboot[main]: device/pci_rom.c: Remove pci_ram_image_start

[Maximilian Brune (Code Review)]

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86349?usp=email )

Change subject: device/pci_rom.c: Remove pci_ram_image_start
......................................................................

device/pci_rom.c: Remove pci_ram_image_start

The variable is modified, but the modified value is never used. So we
might as well stick to the the definition directly. It also fits the
other code with the PCI_VGA_RAM_IMAGE_START definition a little better.

Signed-off-by: Maximilian Brune 
Change-Id: I525143d017c68086f101a638d1472bc607c48cc2
---
M src/device/pci_rom.c
1 file changed, 3 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/86349/1

diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c
index d60720e..d0e9104 100644
--- a/src/device/pci_rom.c
+++ b/src/device/pci_rom.c
@@ -129,8 +129,6 @@
    return rom_header;
 }

-static void *pci_ram_image_start = (void *)PCI_RAM_IMAGE_START;
-
 struct rom_header *pci_rom_load(struct device *dev,
    			struct rom_header *rom_header)
 {
@@ -173,11 +171,10 @@
    }

printk(BIOS_DEBUG, "Copying non-VGA ROM image from %p to %p, 0x%x bytes\n",
-	       rom_header, pci_ram_image_start, rom_size);
+	       rom_header, (void *)PCI_RAM_IMAGE_START, rom_size);

-	memcpy(pci_ram_image_start, rom_header, rom_size);
-	pci_ram_image_start += rom_size;
-	return (struct rom_header *)(pci_ram_image_start-rom_size);
+	memcpy((void *)PCI_RAM_IMAGE_START, rom_header, rom_size);
+	return (struct rom_header *)PCI_RAM_IMAGE_START;
 }

/* ACPI */