Attention is currently required from: Bao Zheng. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48529 )
Change subject: mb/amd/majolica: Add PSP support for board majolica ......................................................................
Patch Set 22:
(2 comments)
File src/mainboard/amd/majolica/Kconfig:
https://review.coreboot.org/c/coreboot/+/48529/comment/71e47528_2bb25cf2 PS20, Line 21: config AMD_FWM_POSITION_INDEX i wonder why this is dropped in newer versions. if i remember correctly, i needed that on mandolin for the build not to fail, since due to the ec firmware being present and the fmap being at the beginning at the flash, the cbfs didn't cover the location that would be used by default
File src/mainboard/amd/majolica/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48529/comment/ade24cb2_e3d19ac1 PS22, Line 7: PHONY+=add_mchp_fw : INTERMEDIATE+=add_mchp_fw those two lines shouldn't be in here; I guess something went wrong during a rebase. see https://review.coreboot.org/c/coreboot/+/49358/6/src/mainboard/amd/majolica/...