Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35553 )
Change subject: util/mainboard/google: Fix hatch variant script
......................................................................
Patch Set 2:
(2 comments)
Patch Set 1:
(2 comments)
I'm always in favour of idempotent scripts hence the suggestion to use mkdir -p.
Not sure if the script has other places where fixes would be useful to make the script idempotent.
https://review.coreboot.org/c/coreboot/+/35553/1/util/mainboard/google/hatch...
File util/mainboard/google/hatch/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35553/1/util/mainboard/google/hatch...
PS1, Line 56: mkdir
Use mkdir -p
Done
https://review.coreboot.org/c/coreboot/+/35553/1/util/mainboard/google/hatch...
PS1, Line 57: -
Use cp -pr "$(SRC)/template/." […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35553
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6f4179014b79ea45d0fcf406ca192046438dbf7
Gerrit-Change-Number: 35553
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Andrew McRae
amcrae@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz
djkurtz@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Sep 2019 03:27:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrew McRae
amcrae@chromium.org
Gerrit-MessageType: comment