Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46219 )
Change subject: mb/facebook/fbg1701: Add VBOOT support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46219/5/src/mainboard/facebook/fbg1...
File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/c/coreboot/+/46219/5/src/mainboard/facebook/fbg1...
PS5, Line 28: config VBOOT_VBNV_CMOS
: depends on VBOOT
: default y
:
: config VBOOT_SLOTS_RW_A
: depends on VBOOT
: default y
:
: config VBOOT_NO_BOARD_SUPPORT
: depends on VBOOT
: default y
:
: config VBOOT_ENABLE_CBFS_FALLBACK
: depends on VBOOT
: default y
nit: Maybe put all the things you need with vboot under
if VBOOT
...
endif
That allows for less boilerplate.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46219
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I641bca58c0f7c81d5742235c8b2c184d13c00c55
Gerrit-Change-Number: 46219
Gerrit-PatchSet: 5
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Nov 2020 13:30:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment