18 Jul
2019
18 Jul
'19
6:16 p.m.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34284 )
Change subject: device/oprom: Lists all supported vesa mode by oprom ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34284/2/src/device/oprom/realmode/x... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/34284/2/src/device/oprom/realmode/x... PS2, Line 239: info
that's a stack variable...
Done
https://review.coreboot.org/c/coreboot/+/34284/2/src/device/oprom/realmode/x... PS2, Line 248: info
... and here you return it right before tearing down that part of the stack.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/34284
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02cba44374bc50ec3ec2819c97b6f5027c58387f
Gerrit-Change-Number: 34284
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Thu, 18 Jul 2019 16:16:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment