Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32938 )
Change subject: nb/intel/sandybridge: Remove variable set but not used
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32938/1/src/northbridge/intel/sandybridge/ra...
File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/#/c/32938/1/src/northbridge/intel/sandybridge/ra...
PS1, Line 1455:
Those are all MMIO reads, where it may be important to push the result of the read to the stack. […]
See CB:32948 commentary.
It's certainly important for the MMIO read to happen, but I don't see how storing the value on the stack (cachelines) could have any importance.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32938
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75f5d821e018932d3f10d84b7ebed362777fb17d
Gerrit-Change-Number: 32938
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 23 May 2019 16:10:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment