5 Oct
2020
5 Oct
'20
6:16 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44476 )
Change subject: ec/kontron/kempld: add option to configure I2C frequency ......................................................................
Patch Set 17: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44476/16/src/ec/kontron/kempld/kemp... File src/ec/kontron/kempld/kempld_i2c.c:
https://review.coreboot.org/c/coreboot/+/44476/16/src/ec/kontron/kempld/kemp... PS16, Line 247: if (config->i2c_frequency) {
Since the only thing you're using `config` for is to get the I2C frequency to use, `config_of` provi […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/44476
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0eb477af10d00eb4f17f9c01209f170b746ad3d
Gerrit-Change-Number: 44476
Gerrit-PatchSet: 17
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Oct 2020 16:16:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment