Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36547 )
Change subject: security/vboot: Add config option to always enable the display ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36547/1/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/36547/1/src/security/vboot/Kconfig@... PS1, Line 170: config VBOOT_ALWAYS_ENABLE_DISPLAY
I looked into a couple of options.
First clear the VBOOT_MUST_REQUEST_DISPLAY. This caused a hang in the display_init_required(). As far as I could see from the file history this is the desired behavior. So overriding it would require an additional config.
What was causing the hang? It looks to me that dead_code() would only trigger a linker error.