Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39343 )
Change subject: vboot: remove extraneous vboot_recovery_mode_memory_retrain
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39343/5/src/soc/mediatek/mt8183/mem...
File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/39343/5/src/soc/mediatek/mt8183/mem...
PS5, Line 179: vboot_check_recovery_request() == VB2_RECOVERY_TRAIN_AND_REBOOT) {
Here's the original CL. […]
Ohhh... so it's literally just supposed to be a recovery boot that reboots automatically. I think I never quite understood how that was meant. It's probably wrong to have it on Kukui here then, too.
I thought we had a requirement to allow the system to automatically trigger a retrain from software, but I guess we don't? Or I guess you could always use flashrom to erase training data manually, too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb88d6862db1782e0218276984e527638b21fd3a
Gerrit-Change-Number: 39343
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Mar 2020 00:05:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment