Attention is currently required from: Zhuohao Lee, Alan Huang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63191 )
Change subject: mb/google/brya/variants/baseboard/brask: Turn off NFC power in S0ix
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I think we could actually add a "power_gpio" to drivers/usb/acpi/chip.h and then add that to the power resource when generating the SSDT in usb_acpi.c. That should do the same thing, but in a less board-specific (read: hacky) way
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63191
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69588c82dfde1744c45c7aff3ac05b80bb16a8f3
Gerrit-Change-Number: 63191
Gerrit-PatchSet: 3
Gerrit-Owner: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 30 Mar 2022 15:04:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment