build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47786 )
Change subject: soc/mediatek/mt8192: Init SSPM
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47786/1/src/soc/mediatek/mt8192/ssp...
File src/soc/mediatek/mt8192/sspm.c:
https://review.coreboot.org/c/coreboot/+/47786/1/src/soc/mediatek/mt8192/ssp...
PS1, Line 11: if (load_blob_file(sspm_file_name, SSPM_SRAM_BASE) == CB_SUCCESS) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47786
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia834852af50e9e7e1b1222ed1e2be20e43139c62
Gerrit-Change-Number: 47786
Gerrit-PatchSet: 1
Gerrit-Owner: tinghan shen
tinghan.shen@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 20 Nov 2020 08:14:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment