Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33842 )
Change subject: src/superio/nuvoton: Add support for NCT5539D
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/33842/8/src/superio/nuvoton/common/early_ser...
File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/#/c/33842/8/src/superio/nuvoton/common/early_ser...
PS8, Line 70: 0x40
0x00
the table in the datasheet is a bit weird; so 0x40 is indeed probably the correct value here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33842
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e979bde53ce3dac1a4f74e7e51a3c6a0149051c
Gerrit-Change-Number: 33842
Gerrit-PatchSet: 8
Gerrit-Owner: Pavel Sayekat
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Pavel Sayekat
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 29 Jun 2019 15:28:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment