Attention is currently required from: Chen Wisley, Kangheui Won, Knox Chiou, Nick Vaccaro, Subrata Banik.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78119?usp=email )
Change subject: mb/google/nissa/var/yaviks: Disable PMC mux conn1 by FW_CONFIG
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Can you use a `probe` statement in devicetree instead?
We only handle storage devices like this because they need to be enabled when fw_config is unprovisioned on first boot in factory, which shouldn't be the case for USB C1.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78119?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifec2066f18f8fbaa593deb44f96817a1493caa86
Gerrit-Change-Number: 78119
Gerrit-PatchSet: 1
Gerrit-Owner: Chen Wisley
wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Knox Chiou
knoxchiou@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Knox Chiou
knoxchiou@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Chen Wisley
wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 26 Sep 2023 22:43:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment