[coreboot-gerrit] Change in coreboot[master]: soc/intel: Allow enable/disable ME via CMOS

[Felix Singer (Code Review)]

Attention is currently required from: Sean Rhodes, SRIDHAR SIRICILLA, Furquan Shaikh, Paul Menzel, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla, Arthur Heymans, Evgeny Zinoviev, Patrick Rudolph, Felix Held.
 Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 )

Change subject: soc/intel: Allow enable/disable ME via CMOS
......................................................................

Patch Set 85:

(4 comments)

File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/52800/comment/c3431575_90569219 
PS85, Line 1057: int send;
               : 	int result;
Declare variables at the beginning of that function.

https://review.coreboot.org/c/coreboot/+/52800/comment/cd07e278_bce1d529 
PS85, Line 1060: struct state_reply {
               : 		struct mkhi_hdr hdr;
               : 		uint32_t rule_id;
               : 	} __packed;
Not sure about this. I would put this at the beginning too.

https://review.coreboot.org/c/coreboot/+/52800/comment/47f1b952_9fdfcbed 
PS85, Line 1065: 	struct state_reply reply;
               : 
               : 	size_t reply_size;
Declare variables at the beginning of that function.

https://review.coreboot.org/c/coreboot/+/52800/comment/e440d269_743b651f 
PS85, Line 1109: 
Remove empty line