Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35907 )
Change subject: mb/google/hatch/variants/helios: Modify touchscreen power on sequence
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35907/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35907/2//COMMIT_MSG@13
PS2, Line 13: TEST
I assume that you tested touchscreen functionality is ok with this CL?
Also, looking at the values, they do not match the timings in that data sheet. Can you tell us why you made the timings longer? Were you seeing a failure before?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35907
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86c920ff1d5c0b510adde8a37f60003072d5f4e7
Gerrit-Change-Number: 35907
Gerrit-PatchSet: 2
Gerrit-Owner: YenLu Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Assignee: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: YenLu Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Fri, 11 Oct 2019 21:48:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment