Attention is currently required from: Frans Hendriks, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49930 )
Change subject: mb/emulation/qemu-q35: Solve lint-001 error
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49930/comment/389fccc2_8728b01a
PS1, Line 9: lint-001-no-global-config-in-romstage error on
This doesn't make any sense. It's a define.
File src/mainboard/emulation/qemu-q35/gm35.h:
PS1:
GM35? Why not Q35?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5ac9eb797de996186282193647313b9f7b42624
Gerrit-Change-Number: 49930
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 27 Jan 2021 20:43:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment