Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34632 )
Change subject: Documentation: Add guidelines for new mainboard ports
......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start...
File Documentation/getting_started/mainboard_template.md:
https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start...
PS3, Line 124:
Remove the blank lines.
https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start...
File Documentation/getting_started/new_mainboard_ports.md:
https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start...
PS3, Line 9: DRAM
Put on line above?
https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start...
PS3, Line 61: descibed
described
https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start...
PS3, Line 61: Recommand
Recommend
https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start...
PS3, Line 65: pc
px
https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start...
PS3, Line 68: of
off
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34632
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I134dbf2341696ba0dd33c3d52bf787b8eaabbdab
Gerrit-Change-Number: 34632
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Aug 2019 12:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment